fix: parse deployment manifests safely with native YAML - #4
Open
juanmardefago wants to merge 1 commit into
Open
juanmardefago wants to merge 1 commit into
juanmardefago wants to merge 1 commit into
Conversation
Replace line-based manifest extraction with graph-ts YAML parsing to avoid indexing failures from CRLF line endings and malformed metadata. Preserve the original manifest and extract schema links, network, source kind, and minimum start block independently, leaving invalid fields unset with warnings. Guard YAML types and missing keys, validate unsigned block numbers and IPFS references, and preserve zero when calculating the minimum start block. Upgrade graph-ts to 0.38.2 and document the Graph Node 0.37.0 requirement. Validation: Arbitrum and L1 test-configuration codegen/builds, targeted lint, and diff checks passed. Matchstick was skipped as requested. The manifest handler and validation helper are identical to the network subgraph implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace line-based manifest extraction with graph-ts YAML parsing to avoid indexing failures from CRLF line endings and malformed metadata. Preserve the original manifest and extract schema links, network, source kind, and minimum start block independently, leaving invalid fields unset with warnings.
Guard YAML types and missing keys, validate unsigned block numbers and IPFS references, and preserve zero when calculating the minimum start block. Upgrade graph-ts to 0.38.2 and document the Graph Node 0.37.0 requirement.
Validation: Arbitrum and L1 test-configuration codegen/builds, targeted lint, and diff checks passed. Matchstick was skipped as requested. The manifest handler and validation helper are identical to the network subgraph implementation.