Add field selection map to types chapter - #238
Open
michaelstaib wants to merge 2 commits into
Open
michaelstaib wants to merge 2 commits into
michaelstaib wants to merge 2 commits into
Conversation
✅ Deploy Preview for composite-schemas ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟡 Changes recommended
The moved spec text includes at least one invalid GraphQL example (and a grammatical error), which should be corrected to keep the specification copy/pasteable and unambiguous.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR relocates the FieldSelectionMap specification from an appendix into the main “Shared Types” chapter, and updates internal references accordingly.
Changes:
- Move the
FieldSelectionMapscalar specification content intoSection 6 -- Shared Types.md. - Rename the shared scalar from
FieldSelectiontoFieldSelectionSetand document it alongsideFieldSelectionMap. - Remove the Appendix A entry from the spec index and update composition text to reference “Shared Types” instead of “Appendix A”.
File summaries
| File | Description |
|---|---|
| spec/Spec.md | Removes the Appendix A link from the spec table of contents. |
| spec/Section 6 -- Shared Types.md | Adds FieldSelectionSet and moves/embeds the full FieldSelectionMap spec content into the shared types chapter. |
| spec/Section 4 -- Composition.md | Updates references from “Appendix A” to “Shared Types” for selection-map validation rules. |
| spec/Appendix A -- Field Selection.md | Removes the appendix file contents (effectively relocating the material). |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+286
to
+288
| type Product { | ||
| shippingCost(partIds: @require(field: "parts[id]")): Currency | ||
| } |
Comment on lines
+1002
to
+1003
| Every field provided in an selected object value must be defined in the set of | ||
| possible fields of that input object's expected type. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.