Conversation
bjorn3
added this pull request to stack #166
September 16, 2026 13:16
bjorn3
force-pushed
the
monitor
branch
2 times, most recently
from
September 17, 2026 15:00
3361ad4 to
3433dbf
Compare
Collaborator
|
Changes look reasonable to me (maybe I've tested it and so far I get some confusing results where the 'SIGTSTP' seems to arrive later than the #! /bin/dash
FOO=H
trap "FOO=A" CONT
trap "FOO=B" TSTP
while true; do sleep 1; echo $FOO; done |
bjorn3
force-pushed
the
monitor
branch
3 times, most recently
from
September 21, 2026 13:51
b0128f5 to
551f4d6
Compare
bjorn3
removed this pull request from stack #166
September 21, 2026 13:52
bjorn3
added this pull request to stack #172
September 21, 2026 13:53
We no longer send SIGWINCH on PTY attach. And SIGWINCH during actual window resizing is non-trivial to test in our test framework.
old_sigset.set_mask() probably already unmasked it for the child, but just to be on the safe side and be clearer move SIGTTOU after forking.
FIXME notify beamctl on backgrounding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a monitor process to be used when a PTY is used. This monitor process is the session leader for the service, allowing it to set the foreground process group of the service PTY. beam-init will forward any api commands to the monitor process as necessary.
Fixes #117