Conversation
|
Amplify deployment status
|
|
Once I fix the type issues and get the preview to work, a proof of concept will be visible at: |
47a4878 to
175805e
Compare
175805e to
435dff4
Compare
435dff4 to
6439eec
Compare
6439eec to
cfa996b
Compare
cfa996b to
2fc83ed
Compare
2fc83ed to
146d0aa
Compare
146d0aa to
495fca9
Compare
495fca9 to
247f7f1
Compare
247f7f1 to
11af048
Compare
11af048 to
2f0f4fa
Compare
2f0f4fa to
4a681ba
Compare
4a681ba to
96f7efa
Compare
96f7efa to
b4971ed
Compare
b4971ed to
565e4db
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 565e4dbd5f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| process.env.GOPATH && isAbsolute(process.env.GOPATH) | ||
| ? process.env.GOPATH | ||
| : join(process.cwd(), process.env.GOPATH); | ||
| const proc = spawn(goBinary, ["build", "."], { |
There was a problem hiding this comment.
You should be able to use just go run ./tooling/cmd/convert-resource/, which will build the binary automatically in the background.
There was a problem hiding this comment.
We'd need to run go run twice for every teleport-resource code snippet, since the plugin shells out to the convert-resource script once for HCL and once for Kubernetes. As far as I understand it, this would add some overhead.
There was a problem hiding this comment.
go should be smart about it and re-use cached binary if source code didn't change.
So it might be simpler to use go run to simplify the code, but this is also ok with me :)
565e4db to
84f7c98
Compare
e37bed7 to
bbf8d9a
Compare
The plugin transforms any code fence with the `teleport-resource` label into a `Tabs` component with separate tabs for `tctl`, the Teleport operator, and the Teleport Terraform provider. It shells out to the script added in gravitational/teleport#67528 to perform the conversion.
These are absolute paths in the Amplify build config now, so there is no need to reassign them in `prepare-files.mts`.
bbf8d9a to
40e93d8
Compare
|
@taraspos Just checking if there's anything left to do here. I think we'll need to merge this before gravitational/teleport#67528 since that PR introduced |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40e93d8026
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Tooling that accesses the Teleport source. The build.assets/tooling module | ||
| # relies on api and lib in the root gravitational/teleport module. | ||
| '*/build.assets/tooling' | ||
| '*/*.go' |
There was a problem hiding this comment.
In the GNU tar path used by the CI/archive build, this pattern is much broader than it looks: with --wildcards, * matches / unless --no-wildcards-match-slash is used (confirmed from tar --help and a local tar extraction check), so */*.go extracts every .go file anywhere in the Teleport archive rather than only the root Go files needed with api and lib. On the Linux archive build this can pull a large, unintended slice of the source tree into each content version, inflating build time and disk/cache usage; constrain the match to root files or add the no-match-slash behavior around these root-only patterns.
Useful? React with 👍 / 👎.
taraspos
left a comment
taraspos
left a comment
There was a problem hiding this comment.
I don't have too much context regarding the work on teleport repo side. But if you're ready to push it forward that's fine with me.
| { | ||
| "name": "18.x", | ||
| "branch": "branch/v18", | ||
| "branch": "paul.gottschling/2026-07-24-resource-converter", |
There was a problem hiding this comment.
Reminder to revert this back before merging:
| "branch": "paul.gottschling/2026-07-24-resource-converter", | |
| "branch": "branch/v18", |
2 participants
The plugin transforms any code fence with the
teleport-resourcelabel into aTabscomponent with separate tabs fortctl, the Teleport operator, and the Teleport Terraform provider. It shells out to the script added in gravitational/teleport#67528 to perform the conversion.