Skip to content

tools/amplify-preview improvements #306

Description

@taraspos

Summary

Following improvements for amplift-preview can be implemented:

  • Make retries-count configurable

    const (
    jobWaitSleepTime = 30 * time.Second
    jobWaitTimeAttempts = 40
    )

  • Set relevant outputs to GITHUB_OUTPUT:

    • Preview App ID
    • Preview Branch Name
    • Preview Job ID

    Those values can be used then to compose copy-pastable command to fetch deployment logs (like aws amplify get-job --app-id <APP_ID> --branch-name <BRANCH_NAME> --job-id <JOB_ID> and printed in case of error:

    - https://github.com/gravitational/teleport/pull/48512#issuecomment-2557357755
    
  • Report failure if retries-count reached

  • Cancel all pending jobs when submitting new one

  • Delete Amplify branches/previews when PR is closed branch is not deleted, to reduce number of "abandoned" previes that count towards limit.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions