build(deps): update major latex-extension - #1209
Open
goldserg wants to merge 1 commit into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the project to support the new major version of the @diplodoc/latex-extension package while keeping compatibility with v1 for the editor and the latex-extension package, and updates the workspace catalog and lockfile accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
packages/latex-extension/package.jsonpeerDependencies list includes@diplodoc/latex-extensionitself, which looks circular; double-check whether this should instead reference a host package (e.g., the editor) or be removed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `packages/latex-extension/package.json` peerDependencies list includes `@diplodoc/latex-extension` itself, which looks circular; double-check whether this should instead reference a host package (e.g., the editor) or be removed.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Relax latex-extension dependency constraints across editor and latex-extension packages and update workspace catalog to the new major version.
Build: