feat(commerce): daff.json specifies driver version for angular.json - #4452
Open
joannalauu wants to merge 11 commits into
Open
joannalauu wants to merge 11 commits into
joannalauu wants to merge 11 commits into
Conversation
joannalauu
force-pushed
the
feat/daff-json
branch
from
April 22, 2026 01:26
b707f52 to
7ed69f3
Compare
joannalauu
commented
Apr 22, 2026
joannalauu
force-pushed
the
feat/daff-json
branch
from
April 22, 2026 06:45
7ed69f3 to
bba9b73
Compare
griest024
force-pushed
the
feat/daff-json
branch
3 times, most recently
from
May 27, 2026 22:27
aaca7f3 to
13b3378
Compare
Member
|
blocked by graycoreio/github-actions#19 |
griest024
marked this pull request as ready for review
May 29, 2026 20:38
griest024
force-pushed
the
feat/daff-json
branch
4 times, most recently
from
June 10, 2026 17:24
dfcfab5 to
0a23f16
Compare
griest024
previously approved these changes
Jun 10, 2026
griest024
force-pushed
the
feat/daff-json
branch
from
August 3, 2026 15:56
0a23f16 to
8dbd2c2
Compare
griest024
previously approved these changes
Aug 3, 2026
griest024
left a comment
griest024
left a comment
Member
There was a problem hiding this comment.
@damienwebdev I've implemented the builders
damienwebdev
reviewed
Aug 3, 2026
| "architect": { | ||
| "build": { | ||
| "builder": "@angular/build:application", | ||
| "builder": "./dist/commerce:application", |
damienwebdev
reviewed
Aug 3, 2026
| }, | ||
| "devDependencies": { | ||
| "@daffodil/branding": "0.0.0-PLACEHOLDER", | ||
| "@daffodil/commerce": "0.0.0-PLACEHOLDER", |
griest024
force-pushed
the
feat/daff-json
branch
from
August 3, 2026 16:19
8dbd2c2 to
d076585
Compare
griest024
marked this pull request as draft
August 3, 2026 16:21
Member
|
@damienwebdev hang on I'm fixing the schematic |
griest024
marked this pull request as ready for review
August 3, 2026 18:55
Member
|
@damienwebdev ready |
15 tasks
|
|
||
| private inmemoryDriver = inject(DaffExternalRouterInMemoryDriver); | ||
| private magentoDriver = inject(DaffExternalRouterMagentoDriver); | ||
| private magentoDriver = inject<DaffExternalRouterDriverInterface>(DaffExternalRouterDriver); |
| { type: NodeDependencyType.Default, version: `^${version}`, name: '@daffodil/dev-tools' }, | ||
| { type: NodeDependencyType.Default, version: `^${version}`, name: '@daffodil/navigation' }, | ||
| { type: NodeDependencyType.Default, version: `^${version}`, name: '@daffodil/external-router' }, | ||
| { type: NodeDependencyType.Dev, version: `^${version}`, name: '@daffodil/cli' }, |
| return tree; | ||
| }; | ||
|
|
||
| export const addBuildCondition = (options: NgAddOptions, projectName_: string): Rule => { |
Member
There was a problem hiding this comment.
This function is poorly named.
| } | ||
| }, | ||
| "else": { | ||
| "if": { |
Member
There was a problem hiding this comment.
We don't target different shopify versions at the moment. Remove this until we do.
| writeFile, | ||
| } from 'fs/promises'; | ||
| import { join } from 'path'; | ||
| import type { PackageJson } from 'type-fest'; |
Member
There was a problem hiding this comment.
Please remove this dep and just do a loose PackageJson type. Maybe one day node gets this on its own somehow.
| writeFile, | ||
| } from 'fs/promises'; | ||
| import { join } from 'path'; | ||
| import type { PackageJson } from 'type-fest'; |
Member
There was a problem hiding this comment.
Move this to application build time as opposed to ahead of build time. We'll need an allowlist key on the options of the builder's to know what can be searched for. Obviously we can allowlist @daffodil by default.
| import { isSupportedPlatform } from '../../../versioning/public_api'; | ||
| import { NgAddOptions } from '../../schema'; | ||
|
|
||
| const shouldScaffoldDaffConfig = (options: NgAddOptions): boolean => |
Member
There was a problem hiding this comment.
Let's extract the generator changes to another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #4437
New behavior
Breaking change?
Additional context
claude was using in the making of this PR.
no docs yet and needs to be pieced up for final merging but is ready for a review of the general idea and functionality