Repository navigation
[Teams] Split out list_teams from get_team details - #54
Merged
Merged
Conversation
**Backgound** list_teams returns a ton of info about teams for a tool which receives a lot of traffic **Change** Split between list_teams and get_team
gremsam
commented
Oct 6, 2026
Comment on lines
+6
to
+9
| // Explicit pick so new API fields (and the multi-KB certificate) stay out of the list. | ||
| export function summarizeTeam({ identifier, name, production, created_at }: Team): TeamSummary { | ||
| return { identifier, name, production, created_at }; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Here is where we're removing the fields
fred-gremlin
previously approved these changes
Oct 6, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Team names containing URL-reserved characters are not encoded before being inserted into the request path.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Splits lightweight team listings from detailed team retrieval to reduce list_teams payload size.
Changes:
- Adds and registers
get_team. - Restricts
list_teamsto summary fields. - Updates types, tests, documentation, and version metadata.
| File | Description |
|---|---|
src/tools/teams.ts |
Implements team summaries and get_team. |
src/tools/index.ts |
Registers the new tool. |
src/client/gremlin.ts |
Expands team typing and fetches individual teams. |
src/resources/index.ts |
Uses the corrected wire-format company ID. |
src/server.ts |
Bumps server version. |
tests/unit/tools-index.test.ts |
Tests team tool behavior. |
tests/unit/gremlin-client.test.ts |
Tests individual-team responses. |
tests/integration/mcp-server.test.ts |
Covers the new tool and summary shape. |
Readme.md |
Documents both team tools. |
package.json |
Bumps package version. |
package-lock.json |
Updates locked version metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Encode teamId in the request URL to handle special characters. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
richbg
approved these changes
Oct 6, 2026
gremsam
enabled auto-merge (squash)
October 6, 2026 22:45
gremsam
disabled auto-merge
October 6, 2026 22:45
gremsam
enabled auto-merge (squash)
October 6, 2026 22:46
| export class GremlinApi { | ||
| private baseUrl: string = getServiceUrl(); | ||
| private userAgent = "@gremlin/gremlin-mcp/2.5.0"; | ||
| private userAgent = "@gremlin/gremlin-mcp/2.6.0"; |
There was a problem hiding this comment.
would there be value in deriving this from the package.json?
Collaborator
Author
There was a problem hiding this comment.
There is a make command which requires this
|
|
||
| export const SERVER_NAME = 'Gremlin Inc Server'; | ||
| export const SERVER_VERSION = '2.5.0'; | ||
| export const SERVER_VERSION = '2.6.0'; |
There was a problem hiding this comment.
would there be value in deriving this from the package.json?
Collaborator
Author
There was a problem hiding this comment.
These come from a build script
fred-gremlin
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
list_teams returns a ton of info about teams for a tool which receives a
lot of traffic
Change
Split between list_teams and get_team