fix: CTORNDSD-654: update btn loader - #18
Merged
Merged
Conversation
… adjust theme dimensions - Updated default theme sizes for `sm`, `md`, `lg`, `xl`, and added `xxl`. - Refactored loader token size variants (`SizeVariant` keys replaced with string literals). - Synced auto-generated documentation and metadata dates.
There was a problem hiding this comment.
Pull request overview
Updates the UI theme tokens to make the Button’s loading spinner smaller by default, along with regeneration of derived artifacts (theme JSON, snapshots, AI docs) to reflect the token changes.
Changes:
- Adjust
button.loader.attrs.sizedefault frommd→sm. - Simplify
loadertoken size maps to use string keys (xs|sm|md|lg|xl) instead ofSizeVariantcomputed keys. - Regenerate derived outputs impacted by token changes (Storybook
defaultTheme.json, snapshot, AI docs timestamps).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/ui/src/tokens/loader.ts | Replaces SizeVariant computed keys with string size keys in loader tokens. |
| libs/ui/src/tokens/button.ts | Changes default Button loader size token to sm. |
| libs/ui/src/components/molecules/AttachmentFile/snapshots/AttachmentFile.test.tsx.snap | Updates snapshot for Loader styling/classname change. |
| libs/ui/src/ai/README.md | Updates auto-generated components block timestamp. |
| libs/ui/llms.txt | Updates auto-generated components block timestamp. |
| libs/ui/.storybook/public/defaultTheme.json | Regenerates theme JSON to reflect updated tokens (incl. button loader size). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tjeleascov
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.