Feature/ctorndsd 646 - #20
Merged
Merged
Conversation
…and tooling for bundle size verification - Deleted outdated SSR declarative shadow DOM harness files (`ssr-dsd-hydrated.html` and `ssr-dsd-static.html`). - Added migration documentation for styling and theming (`docs/webcomponents-migration/06-styling-theming.md`) and component complexity matrix (`docs/webcomponents-migration/12-complexity-matrix.md`). - Introduced bundle size regression check script (`check-bundle-size.mjs`) with tolerance support for CI validation. - Updated baseline creation and verification for `measure:web-components-size`.
…rence The decision README, the options matrix, and the monorepo doc still quoted the pre-646b bundle measurements (9.11 / 16.38 / 113.18 kB). Those were superseded by 10-performance-report.md after ElementInternals and ::part() landed, so the summary a reviewer reads to approve disagreed with the reproduction command it cites (npm run check:web-components-size). Align all three to the current measured figures (11.06 / 17.94 / 105.72 kB) and cite 10-performance-report.md rather than FINDINGS.md section 3. FINDINGS.md section 3 keeps its original numbers by design - it is the chronological log, and section 18 already records the supersession. Also fix the branch reference, which still read feature/CTORNDSD-580. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Executing every step of the demo walkthrough surfaced two tangled problems on the SSR/DSD pages. Only one was a harness bug. Fixed - the harness rendered without a theme. ssr-dsd-render.ts bound no `.theme`, so every token resolved to its own placeholder fallback and emitted `font-family:theme.font.family;font-size:font.size.h1` - invalid CSS the browser discards, leaving the heading in Times. That is the real components' own themeless behavior (FINDINGS.md sections 13, 16), not an SSR defect, but it made the page contradict its own "visibly styled" instruction. Binding defaultTheme matches fidelity-check.tsx and form-participation-check.ts; gd-typography now server-renders "Fira Sans", 48px, 56px with zero unresolved literals. Not fixed, architectural - binding the theme did not style gd-button. Section 12's rewrite moved its theme CSS into a per-instance Constructable StyleSheet. Only `static styles` and inline style attributes serialize into a <template shadowrootmode>; adoptedStyleSheets cannot, and with zero JS nothing runs to adopt one. Section 18.7 noted "the server-rendered output never carried it either way" but read it as harmless and never revisited section 2's "correctly styled" claim. Scope is 1 of 5 atoms - the others use styleMap. The mechanism at fault is the same shared-stylesheet cache credited in section 18.1 for the 50% mount / 57% update improvement, so the performance strategy and the no-JS story are in direct tension for the remaining 35 ports. - ssr-dsd-render.ts: bind defaultTheme; rewrite both pages' copy to state what each element actually demonstrates - ssr-dsd-hydrate-check.ts: assign theme on hydration and record the button background before/after plus adopted-sheet count, read after getAnimations() settles so the background-color transition is not caught mid-flight - FINDINGS.md: new section 20; supersession note on section 2 - 09-ssr-hydration.md, docs README: narrow the unqualified zero-JS styling claim - DEMO.md: new verified 3-minute demo script verify:web-components exits 0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Implement `gd-button` form submission behavior for `type="submit"` and `type="reset"`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.