fix(curiocity): fail all-skipped runs as no runnable trials - #335
Open
atomicdjt wants to merge 8 commits into
Open
fix(curiocity): fail all-skipped runs as no runnable trials#335atomicdjt wants to merge 8 commits into
atomicdjt wants to merge 8 commits into
Conversation
Contributor
Rosetta Triage ReviewSummary: Fixes #326 — a Curiocity suite where every selected trial resolves to Findings:
Caveats:
Automated triage by Rosetta agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326.
Summary
Treat a non-empty Curiocity run in which every resulting trial is skipped as having no runnable trials, returning ExitCode.CONFIG_ERROR (2) instead of success.
This preserves the existing semantics for individual skipped trials: a skipped trial remains non-fatal when at least one other trial is runnable.
Changes
return exit code 2 when every selected trial resolves to skipped
preserve existing mixed runnable + skipped behavior
add unit coverage for both cases
add an end-to-end regression covering the missing/mistyped-agent path from #326
Verification
Verified on commit b80f055:
CI Curiocity ✅
type validation ✅
package build ✅
full Curiocity test suite ✅
CodeQL Advanced ✅
The implementation intentionally reuses the existing CONFIG_ERROR / exit-code-2 contract for “no runnable trials” rather than changing per-trial skipped semantics or introducing a new exit code.