#173 [ROSETTA] dangerous-actions hook: MCP cmd/shell_command fields can't carry override marker - #358
Open
isolomatov-gd wants to merge 1 commit into
Open
#173 [ROSETTA] dangerous-actions hook: MCP cmd/shell_command fields can't carry override marker#358isolomatov-gd wants to merge 1 commit into
isolomatov-gd wants to merge 1 commit into
Conversation
Contributor
Rosetta Triage ReviewSummary: This PR fixes the MCP override-marker gap for Findings:
Validation:
Automated triage by Rosetta agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173
Summary
cmdandshell_commandregression coverage.Testing
npm --prefix src/hooks run checknpm --prefix src/hooks exec vitest run tests/dangerous-actions.test.ts(201 passed)python3 scripts/pre_commit.pywith a writable temporary npm cache (35 files, 1,446 hook tests passed)Assumptions
MCP_PATH_FIELDSremains intentionally excluded from marker eligibility, as specified in the approved plan.