Show DKIM keystore status in the key generation dialog - #22
Open
gott-alexander wants to merge 1 commit into
Open
gott-alexander wants to merge 1 commit into
gott-alexander wants to merge 1 commit into
Conversation
generateDkimKeys now reports whether the private key was pushed into the DKIM keystore. Show a success note when it was, and only fall back to the manual post-install commands when the keystore push failed or an older backend returned the bare public key.
gott-alexander
force-pushed
the
feature/redis-dkim-keys
branch
from
September 16, 2026 21:09
311a368 to
48fccc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DKIM key generation dialog currently always displays manual shell
commands to install the generated key into grommunio-antispam, because the
API historically could not place the key itself. With the new keystore
support in admin-api (
generateDkimKeysreturns{pubKey, redisStored, redisError}), the dialog can report the actual stateinstead.
Changes
src/components/Dialogs/dns/GenerateDkimKeys.tsx:stored in the keystore automatically,
the push failed or an older backend still returns the bare public key
string (fully backward compatible).
Verification
Built and exercised against a backend with the keystore enabled (success
note shown, no manual commands) and with it disabled (manual instructions
shown as before).