Per-domain SMTP gateway tab in the domain details - #25
Open
gott-alexander wants to merge 11 commits into
Open
gott-alexander wants to merge 11 commits into
gott-alexander wants to merge 11 commits into
Conversation
Adds a new 'SMTP gateway' tab to the domain details view that lets
admins configure the per-domain outbound SMTP server (smart-host)
without leaving the web UI.
Changes:
* `src/containers/SmtpGateway.tsx` — new component that renders
the form (host, port, encryption, username, password, from
address, description) and uses the `useAPI` hook to talk to
the new REST endpoint mounted by grommunio-admin-api. Password
field is masked and only sent on save when populated.
* `src/containers/DomainDetails.tsx` — fourth tab is rendered
conditionally and a ref-based handle lets the parent page
invoke `saveSmtpGateway` from the toolbar Save button, so the
existing save flow keeps working.
Companion changes: grommunio/gromox#<PR> and
grommunio/admin-api#<PR>.
from_address is no longer consumed anywhere (smart-host routing is handled by the MTA); the form field had no effect.
Fix the header comment that still described an onSave prop from an earlier iteration (the component uses an imperative handle), and drop the unused isValid() handle export.
This reverts commit 9da7a1d.
This reverts commit 7fe45fb.
…gott-alexander/admin-web into feature/per-domain-smtp-gateway
Member
|
That commit list needs clean-up. There should be no self-reverts and no merge objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an "SMTP gateway" tab to the domain details view, allowing
administrators to configure a per-domain outbound relay (smart-host):
host, port, encryption mode, credentials, description and an
enable/disable toggle.
Changes
src/containers/SmtpGateway.tsx(new): the gateway form. It is acontrolled component that exposes its data buffer to the parent via an
imperative handle (
forwardRef/useImperativeHandle) — the samepattern as the "Disabled plugins" tab, so the domain details' existing
Save button drives persistence and no separate save flow is introduced.
The password field follows the common password-field UX: it is sent
only when edited; leaving it empty keeps the stored password, and a
passwordSetflag from the API indicates whether one is stored.src/containers/DomainDetails.tsx: register the fourth tab and routethe Save button to a
PUT /api/v1/domains/<ID>/smtpGatewayrequestwhen the tab is active; errors from the backend are surfaced through
the existing snackbar.
Verification
Built and verified the production bundle contains the gateway tab; form
round-trip against the API (save, reload, password-keep behaviour,
backend validation errors shown on invalid input).
I deleted the wrong one while testing.