Skip to content

Pitch Strength Calculation #9

Description

@akustiker

k = np.multiply(k, np.sqrt(1.0 / erbs_frequencies))

I once had a discussion with @sstrahl about whether this line is correct. Semantically, this solution should be cleaner:

# f_prime / f
q = erbs_frequencies / pitch_candidate
# Apply envelope
k = np.multiply(k, np.sqrt(1.0 / q))

In my tests, I did not see a difference when changing it, most likely because of the normalization step that follows:

k = k / np.linalg.norm(k[k > 0])

So, maybe this could be changed with future updates?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions