transport: handle ipv6 endpoints when tls is enabled - #2423
Open
bouk wants to merge 3 commits into
Open
Conversation
bouk
force-pushed
the
bouk/normalize-ipv6-host
branch
from
October 9, 2025 13:16
fbb1904 to
4ee843b
Compare
Contributor
|
Hey @bouk ! I'm a maintainer on grpc-rust, and am going through old PRs as we halt development on tonic in favor of the new official library. It looks like this was never merged, despite being a reproducible issue. (I had Gemini reproduce it, putting the report and code on this branch: https://github.com/nathanielford/grpc-rust-testbed/tree/repro/ipv6-tls-pr2423 I went ahead and merged all the changes from master and moved the code you wrote to the function ( |
Author
|
Yeah sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2422 see that issue for context