xds-client: reset backoff only after first response - #2837
Merged
Conversation
Per gRFC A78, establishing an ADS stream is not sufficient to declare a connection healthy. The connection transitions to healthy (and resets backoff) only once the first DiscoveryResponse is received.
Member
Author
|
CC @W4lspirit |
W4lspirit
reviewed
Aug 26, 2026
I had some last-minute refactors that I reverted, but when I reverted them I messed up the syntax.
Health is very broken; it needs an overhaul, not a small patch
ejona86
changed the title
YutaoMa
approved these changes
Aug 27, 2026
YutaoMa
left a comment
YutaoMa
left a comment
Contributor
There was a problem hiding this comment.
thanks, I can work on fixing the metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per gRFC A78, establishing an ADS stream is not sufficient to declare a connection working.