Skip to content

Test gaps and Metrics.Poller supervision #18

Description

@gsmlg

Test gaps

  • No tests for Caddy.Server.Embedded (only test/caddy/server/external_test.exs exists)
  • No tests for Caddy.Metrics.Parser (only poller_test.exs)
  • No transport error-path tests for Caddy.Admin.Request against a real unix socket

Metrics.Poller supervision

config :caddy, metrics_enabled: true and metrics_interval are documented in Caddy.Metrics.Poller, but the poller is not part of the supervision tree — it is manual-start only. If it's meant to be config-driven, Caddy.Supervisor should conditionally start it; otherwise the config options should be removed from the docs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions