Using LineUpEnhanced API to Enhance Football Substitutions - #16496
Draft
williammead wants to merge 4 commits into
Draft
Using LineUpEnhanced API to Enhance Football Substitutions#16496williammead wants to merge 4 commits into
williammead wants to merge 4 commits into
Conversation
Co-authored-by: williammead <285652121+williammead@users.noreply.github.com>
Co-authored-by: Jake LK <1731150+Jakeii@users.noreply.github.com>
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
williammead
marked this pull request as draft
July 31, 2026 10:53
williammead
changed the title
williammead
added
the
maintenance
github-actions
Bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Uses the new data from the PA LineUpEnhanced API to show who is replacing whom when substitutions occur. This involved a change to the parsing and storing of data coming from Frontend, as well as a change to the LineUps component where we actually show the players' names.
N.B. The test fixture for parsing match data needed to be updated to include the new substitution data but I don't believe that data is still readily available so I have replaced the fixture with a new one complete with substitutions.
Why?
Providing more detailed substitution information has been asked for by the sports desk.
How has this change been tested?
Screenshots