Conversation
Member
|
Can you add a test? |
Member
Author
|
Tests added 😁 |
Kinfe123
approved these changes
Jan 6, 2026
IlyaSemenov
suggested changes
Sep 7, 2026
| abortSignal = new AbortController(); | ||
|
|
||
| const abort = (err?: any) => abortSignal?.abort(err); | ||
| event.node.req.once("close", abort); |
Contributor
There was a problem hiding this comment.
This listens on the request stream, so it fires when the body has been read, not when the client
disconnects. On a POST with a streaming response the signal is aborted before the handler writes
anything. It happens to work with GET because nothing reads the body.
srvx (which is what h3 v2 works on) already does this correctly in its node adapter:
res.once("close", () => {
if (req.errored) abort(req.errored);
else if (!res.writableEnded) abort();
});|
|
||
| const abort = (err?: any) => abortSignal?.abort(err); | ||
| event.node.req.once("close", abort); | ||
| event.node.req.once("end", abort); |
Contributor
There was a problem hiding this comment.
With proper fix (see above) this is not needed.
| const controller = new AbortController(); | ||
| const response = await client.request({ | ||
| path: "/abort", | ||
| method: "GET", |
Contributor
There was a problem hiding this comment.
This should include a test for POST, too; it would surface the problems in the current implementation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1204