Remove useless comments and tests - #149
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes comments that restate the code and tests that only check lookup tables. Behaviour is unchanged; only comments, tests, and imports those deletions left unused are removed.
Comments
References to the previous gateway, removed or rephrased to state the fact itself, in:
api-keys.ts,users.ts,proxy.ts,health.ts,rate-limit.ts,etag.ts,webhooks.ts,moderations.ts;allowed-replicate-model-versions.ts;lib/format.ts("Ported from the old gateway").Facts that still matter stay, e.g. "Defaults to $3", RateLimit-* following IETF draft-6, and the balance fields kept for monitors.
Section dividers in
replicate.tsandbilling/locks.ts.Doc comments that repeat a name or signature, in
lifecycle.ts,request-events.ts,hackclub.ts,metered-body.tsandreplicate/metering.ts.A misleading test comment in
metered-body.test.ts: "Today's Replicate metering lost…" became "…once lost…", since the bug is fixed.Tests deleted
replicate/pricing.test.ts, "describePricing summarises both pricing kinds": it asserts the exact text of a display helper.routes/replicate.test.ts, "every allowlisted version belongs to an allowlisted model": it compares two config tables.Tests guarding money arithmetic, streaming and cancellation, auth, CSRF, SSRF, billing invariants and end-to-end flows are untouched. "JEV_MODEL accepts only the Jev family" stays too, because that regex is a billing guard.
Screenshot
🤖 Generated with Claude Code