Repository navigation
🐛 fix: update runs from $HOME, so a deleted cwd no longer breaks it - #87
Merged
Merged
Conversation
Typed in a removed worktree, every tool update() starts inherits the dead cwd and dies on its own getcwd check (brew, npm, uv, gem). Typed inside a project, asdf shims pick that project's node/ruby instead of the global ones. update() now warns when its cwd is gone, runs from $HOME, and puts the shell back in an always block — which also kills the sudo keepalive on ^C, where the old EXIT trap never fired. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
updatefrom a removed worktree: brew refuses (The current working directory must exist), npm dies inuv_cwd, uv andgem updateingetcwd. Separately, asdf shims resolve node/ruby from the cwd's.tool-versions, soupdateinside a project upgraded that project's toolchain, not the global one.Fix
update()warns on stderr when its cwd no longer exists, runs every step from$HOME, and restores the caller's directory (or leaves the shell in$HOMEif it is gone).{ } always { }; replaces the EXIT trap, so the sudo keepalive is also killed on ^C (the trap never fired there).tests/update.bats: stubbed brew/npm/uv/gem/sudo; live cwd, deleted cwd, refused sudo. Mutation-checked.🤖 Generated with Claude Code