Repository navigation
✨ feat: 🩺 update runs machine-local update.check commands after the upgrades - #90
Merged
Merged
Conversation
…pgrades A brew upgrade installed a softnet release that serves DHCP itself, so tart's default resolver lost every CI VM on the work Mac runner, and macOS CI was down for about two hours before anyone connected it to the upgrade. update() is what ran that upgrade, and the moment right after it is when a check would have pointed straight at it. So update() runs every `update.check` command from git config after the no-sudo upgrades. The list is machine-local and overlay-supplied: what a given machine needs checked (here, a CI runner's own doctor) is identity the public repo must not carry. A failing check never stops the update, and failures are repeated in a red banner at the very end, past the softwareupdate and gem output that would otherwise bury them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
update()now runs everyupdate.checkcommand from git config right after the no-sudo upgrades (brew, npm, uv). The list is repeatable and machine-local, supplied by an overlay; this repo names none. A failing check never stops the update, and each failure is repeated in a red banner at the very end.Why
A
brew upgradeinstalled softnet 0.24.0, which serves DHCP itself.tart ipcould no longer find CI VMs, and a Mac CI runner was down for about 2 hours.update()is what ran that upgrade, so the moment right after it is when a check would point straight at the cause. The runner's own checks (its doctor, plus "softnet is still pinned") belong in the work overlay asupdate.checkentries.Verified
bats tests/update.bats: 6 pass, 2 of them new.%.update.checkconfigured, nothing extra is printed.CLAUDE.md, package lists section, including the;quoting note.🤖 Generated with Claude Code