Reduce sync demodulation FFT work - #1061
Open
Josalo-III wants to merge 1 commit into
Open
Conversation
Use the existing phase-adjusted half-spectrum for the sync-only path, avoiding a full transform, inverse transform, and time-domain roll. Extend the deterministic NTSC and PAL comparisons to cover sync demodulation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Use the existing phase-adjusted real-FFT filter for sync-only demodulation.
Motivation
The sync-only path still performed a full FFT, full inverse FFT, and time-domain roll for a real-valued result. The main demodulation path already precomputes the equivalent positive-frequency filter with its sample offset applied in the frequency domain.
Related Issues
N/A
Changes Made
rfftandirfft.Testing
nix develop --command python -m pytest -q— 84 passed.nix develop --command python -m pytest -q tests/test_demod_fft.py— 2 passed.Screenshots (if applicable)
N/A
Additional Notes
No dependency or output-format changes.