Fix ld-find-start nominal start validation - #1063
Open
JoeyLemur wants to merge 2 commits into
Open
Conversation
JoeyLemur
marked this pull request as ready for review
August 17, 2026 06:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Makes
ld-find-startvalidate the nominal--startframe using the same sequential field relationship asld-decode. It now returns a start only when the first eight decoded fields have a stable phase sequence.Motivation
The finder could recover content too late after a positive sync probe, then return a pre-roll frame whose nominal
--startposition still decoded unstable fields. Onghosts_of_mississippi_s2.ldf, frame 360 produced phase-sequence mismatch warnings while frame 363 was a safe start.Related Issues
N/A
Changes Made
prevfieldstate, restoring RF decoder parameters between candidates, and limit the search to one source second before VBI.unvalidated(exit 2/no stdout) and clarify that reportedreadlocis the first decoded field sample.Testing
python -m pytest -q; 91 passed).ld-find-start /Users/epowell/ld/ghosts_of_mississippi_s2.ldfselects--start 363; a shortld-decode --start 363run emitted no phase-sequence mismatch warnings.Screenshots (if applicable)
N/A — command-line behavior only.
Additional Notes
If VBI is confirmed but no nominal start validates within the bounded window, the tool deliberately emits no
--startargument rather than guessing.