Hide the "Studies with matching topics" discovery chip - #65
Merged
Merged
Conversation
Discovery ANDs keyword filters, and the chip sends every topic found in the matches. Two to four topics still return studies, but broader instruments produce six or more (SCARED child alone gives six at the default 70% threshold), which returns nothing. With both chips hidden the Discover card no longer renders; the per-match Discovery links are unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for harmony-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Studies with matching topics" chip links to Discovery with one
topics=parameter for every topic found in the matches. Discovery combines keyword filters with AND (contains_allinharmony_discovery_core/util.py), so the link only returns studies tagged with every topic.Measured against the live Discovery API:
Broad instruments routinely land on an empty search, and switching Discovery to OR isn't practical. So this hides the chip behind
SHOW_TOPICS_CHIP = false, next toSHOW_INSTRUMENTS_CHIPfrom #63. With both flags off, the Discover card doesn't render.The per-match Harmony logo links (
/search/?query=<both question texts>) and the Catalogue Mental Health card are unchanged.CI=true npm run buildandbuild:HarmonyExportpass locally. The minifier drops the chip code from the bundle, and the per-match link is still there.🤖 Generated with Claude Code