Skip to content

Release: fix Excel export crashing after Share / Save #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronnyTodgers merged 2 commits into from
Sep 24, 2026
Merged

Release: fix Excel export crashing after Share / Save #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22352bc
Keep instrument refs on live results when sharing or saving
Sep 24, 2026
317aa70
Merge pull request #67 from harmonydata/fix/share-strips-instrument-refs
ronnyTodgers Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/contexts/DataContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,14 +300,14 @@ export function DataProvider({ children }) {
return addDoc(collection(db, "mismatches"), m);
};
const prepForFireStore = (harmonisation) => {
harmonisation.apiData.instruments.map((instrument) =>
instrument.questions.map(
(question) =>
//This is a circular reference but can't be stored
delete question["instrument"]
//question.instrument is a circular reference so can't be stored; drop it
//from a copy rather than deleting it from the live apiData, which the
//results page (and Excel export) still rely on after a share or save
harmonisation.apiData = JSON.parse(
JSON.stringify(harmonisation.apiData, (key, value) =>
key === "instrument" ? undefined : value
)
);
harmonisation.apiData = JSON.parse(JSON.stringify(harmonisation.apiData));
console.log("prepped");
console.log(harmonisation);
return harmonisation;
Expand Down
Loading