Implement adaptive chunk sizes / adaptive speed benchmark results - #2427
Open
mr-creditcard wants to merge 13 commits into
Open
Implement adaptive chunk sizes / adaptive speed benchmark results#2427mr-creditcard wants to merge 13 commits into
mr-creditcard wants to merge 13 commits into
Conversation
mr-creditcard
force-pushed
the
2295-adaptivechunks
branch
2 times, most recently
from
August 11, 2026 08:38
3c4d5fc to
0bc5c8a
Compare
…ems - to-be-removed.
Addresses requirement mentioned in hashtopolis#729 (comment)
mr-creditcard
force-pushed
the
2295-adaptivechunks
branch
from
August 11, 2026 08:41
0bc5c8a to
f9c6e4c
Compare
mr-creditcard
marked this pull request as ready for review
August 11, 2026 08:42
jessevz
requested changes
Aug 24, 2026
jessevz
left a comment
jessevz
left a comment
Contributor
There was a problem hiding this comment.
Code looks really good, apart from the small syntax error phpstan picked up and the postgres syntax it looks great. I have not tested the code yet but once these things are fixed I can do a test run. Maybe @s3inlc also want to review this
| @@ -0,0 +1,2 @@ | |||
| INSERT INTO `Config` (`configId`, `configSectionId`, `item`, `value`) VALUES | |||
Contributor
There was a problem hiding this comment.
I think some of the tests are failing because of the backticks, this is mysql syntax and not postgres syntax
| // chunk calculation times for small chunks can be pretty inaccurate this is a pretty safe and reasonable | ||
| // multiplier. Keep in mind the chunk duration will not be tuned down, only up. So once overshot, you're | ||
| // stuck with that time for the remainder of the task. | ||
| $differenceToChunk = ($differenceToChunk > 1.5) ? 1.5 : $differenceToChunk; |
Contributor
There was a problem hiding this comment.
bit nitpicky of me but the magic number 1.5 would be cleaner in a variable ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the work done by @0xVavaldi in #729. I have cherry-picked their commits and added my own on top in an attempt to keep attribution in place. It addresses issues #551 & #2295.
The aforementioned PR has a number of requirements set by @s3inlc in the comments which have remained unaddressed thusfar, this PR aims to implement these. The changes include:
APISendProgress.php's switch statement overDHashcatStatus. In commit dbd4b32 this logic is moved toTaskUtils.phpinstead and is called with a function call.Did some quick tests with this code and it seems to work fine. Would appreciate someone else testing this as well though!
Closes #551 & #2295.