Added patching to preprocessor of task - #2466
Open
jessevz wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds APIv2 support for updating a task’s preprocessorCommand (including purging/reset behavior) to address the backend portion of issue #2413, and extends the API test suite to cover this update path.
Changes:
- Introduces
TaskUtils::changePreprocessorCmd()to validate and persistpreprocessorCommandchanges while purging the task. - Wires
Task::PREPROCESSOR_COMMANDinto TaskAPI’s update handlers to allow PATCH/PUT updates via APIv2. - Adds APIv2 tests verifying successful updates and blacklist character rejection for
preprocessorCommand.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/inc/utils/TaskUtils.php | Adds a helper to update and purge task state when preprocessorCommand changes. |
| src/inc/apiv2/model/TaskAPI.php | Enables APIv2 updates for preprocessorCommand via update handlers. |
| ci/apiv2/test_task.py | Adds tests covering update success and blacklist validation for preprocessorCommand. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves backend part for #2413