Fix broken agent assignment, now use helper instead of CRUD method - #814
Open
novasam23 wants to merge 3 commits into
Open
Fix broken agent assignment, now use helper instead of CRUD method#814novasam23 wants to merge 3 commits into
novasam23 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hashtopolis/server#2459
Changes to the backend made
benchmarka required field, this is what broke this and caused the bug.I made it so that assigning the agent now uses the helper instead of a plain CRUD method, which is better anyway because helpers can be stuffed with business/application logic which might apply when assigning agents.