Repository navigation
cabal-install: drop confusing deprecated msgs for perfer-oldest/coverage - #12365
Merged
Merged
Conversation
TeofilC
force-pushed
the
wip/T12357
branch
2 times, most recently
from
September 18, 2026 16:18
de8e6d6 to
41e259f
Compare
TeofilC
marked this pull request as ready for review
September 19, 2026 15:39
Member
Author
|
I have not added a changelog entry, but I'm happy to do so if folks would like |
fgaz
approved these changes
Sep 19, 2026
fgaz
left a comment
fgaz
left a comment
Member
There was a problem hiding this comment.
Looks good, thank you! I'll let the others decide about the changelog entry
Collaborator
|
it has been our practise to require changelogs for changes in cabal terminal output. These are user-facing and users can be interested in reading about such changes in release notes. Arguably, in this case removing messages isn't that interesting. But it's easier to stick to the rule rather than guess. |
Member
Author
|
Added a changelog fragment |
The prefer-oldest and library-coverage arguments have now been superceded by new ones. We used deprecation messages that referred to the Cabal spec to communicate this, but this is wrong and confusing. cabal-install flags have nothing to do with the Cabal spec! Resolves #12357
Member
|
Please set the merge_me label to the merge process started. Let me know if you can't. |
mergify
Bot
added
ready and waiting
Contributor
Merge Queue Status
This pull request spent 1 hour 50 minutes 37 seconds in the queue, including 1 hour 39 minutes 46 seconds running CI. Required conditions to merge
|
44 of 84 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prefer-oldest and library-coverage arguments have now been superceded by new ones. We used deprecation messages that referred to the Cabal spec to communicate this, but this is wrong and confusing.
cabal-install flags have nothing to do with the Cabal spec!
Resolves #12357
Please read Github PR Conventions and then fill in one of these two templates.
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: