Skip to content

Fix reusable release - #12372

Merged
mergify[bot] merged 2 commits into
haskell:masterfrom
ffaf1:fix-reusable-release
Sep 26, 2026
Merged

mergify[bot] merged 2 commits into
haskell:masterfrom
ffaf1:fix-reusable-release

Conversation

@ffaf1

@ffaf1 ffaf1 commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

This should fix #12371.
I have tested this for Win, but not for FreeBSD as I do not have a runner available.
If anyone knows how to test on FreeBSD, let me know.


  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Install native Node for GitHub Actions
Non-native `git` mangles win path.
@ffaf1
ffaf1 force-pushed the fix-reusable-release branch from 933611c to bf9e881 Compare September 22, 2026 10:01
@ffaf1
ffaf1 requested a review from hasufell September 22, 2026 17:14

@ulysses4ever ulysses4ever left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Mikolaj Mikolaj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew. That could have gone worse. Well done.

@mergify mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label Sep 24, 2026
@Mikolaj

Mikolaj commented Sep 25, 2026

Copy link
Copy Markdown
Member

Any more reviews please? If not, shall we mark it high priority?

@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Sep 26, 2026
@mergify

mergify Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-09-26 05:16 UTC · Rule: squash-merge · triggered by rule Put pull requests in the squash+merge queue
  • ✅ Checks passed · on draft merge queue: checking #12372 on master (773c039) #12377
  • ✅ Merged — 2026-09-26 06:59 UTC · at ca85b6dc7d2a1404e45429c7a73c83a4ea885219 · squash

This pull request spent 1 hour 43 minutes 10 seconds in the queue, including 1 hour 32 minutes 22 seconds running CI.

Required conditions to merge
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify
mergify Bot merged commit ca85b6d into haskell:master Sep 26, 2026
78 checks passed
@mergify mergify Bot removed the queued label Sep 26, 2026
@zlonast

zlonast commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

@mergify backport 3.18

@mergify

mergify Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

backport 3.18

✅ Backports have been created

Details

Cherry-pick of ca85b6d has failed:

On branch mergify/bp/3.18/pr-12372
Your branch is up to date with 'origin/3.18'.

You are currently cherry-picking commit ca85b6d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/reusable-release.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot mentioned this pull request Sep 26, 2026
2 tasks
zlonast added a commit that referenced this pull request Sep 26, 2026
* Fix FreeBSD reusable release

Install native Node for GitHub Actions

* Fix Windows reusable release

Non-native `git` mangles win path.

(cherry picked from commit ca85b6d)
mergify Bot added a commit that referenced this pull request Sep 26, 2026
@ffaf1
ffaf1 deleted the fix-reusable-release branch September 28, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days priority: high 🔥 ready and waiting Mergify is waiting out the cooldown period release squash+merge me Tell Mergify Bot to squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build and release is broken

5 participants