Repository navigation
Fix reads from vaults without a display name - #164
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vaults with an empty or absent
vault_nameinvault.jsoncan unlock successfully, butGetEntriesandGetAllFieldsthen reject them withvault is not initialized. This makes commands such aslist,show, andpassfail even thoughdryrunsucceeds.Use the database connection to check initialization, without treating the optional display name as a prerequisite. Add regression tests for empty and absent names that open a copy of the existing test fixture, read entries and fields, and decrypt a field. Unopened vaults must still reject both read methods.
Validation:
go test ./...,go vet ./..., and a native macOS arm64 build passed.