Repository navigation
fix(client): build the User-Agent from the assembly version - #22
Merged
hazeliscoding merged 1 commit intoOct 21, 2026
Merged
Conversation
The hardcoded QuickbaseNet/1.0.1 went stale with each release; the package is at 1.0.2.
hazeliscoding
approved these changes
Oct 21, 2026
hazeliscoding
left a comment
hazeliscoding
left a comment
Owner
There was a problem hiding this comment.
LGTM, thanks also for the AI-usage transparency, not a lot of people do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
QuickbaseClientsent the hardcodedUser-Agent: QuickbaseNet/1.0.1, but the package is at 1.0.2. As the issue suggests, the constant is now astatic readonlybuilt fromtypeof(QuickbaseClient).Assembly.GetName().Version.ToString(3), so it follows<Version>(and the tag-driven release versions) without editing the file. No version number is left inQuickbaseClient.cs.Test:
QuickbaseClientTests.Constructor_SetsUserAgentFromAssemblyVersioncreates its own client (not the shared_client, which replacesClient). It checksclient.Client.DefaultRequestHeaders.UserAgent.ToString()againstQuickbaseNet/plus the assembly's three-part version. Onmainit fails withExpected: QuickbaseNet/1.0.2, Actual: QuickbaseNet/1.0.1.I ran it offline in the .NET 8 SDK container on Linux.
dotnet buildsucceeds for all five targets (netstandard2.0, netstandard2.1, net5.0, net6.0, net48), anddotnet testpasses 8 tests, 0 failed.Note: I used Claude Code while working on this.