Repository navigation
Conversation
Build() sets Options only when one of them was called, and skip and top are left out of the JSON at their default, so Skip(100) alone doesn't also send top: 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
QuickbaseQueryBuildergetsSkip(int count)andTop(int count), each returning the builder and each with an XML doc comment. They store anint?.Build()setsOptionsonly when one of them was called, with the other left at 0. OtherwiseOptionsstaysnull, as today.Options,skipandtopnow useDefaultValueHandling = DefaultValueHandling.Ignore, soSkip(100)alone serializes"skip":100with no"top"key.compareWithAppLocalTimeis unchanged.QueryAllRecordsis left out, as the issue says.Tests: new
QuickbaseNet.UnitTests/Tests/QuickbaseQueryBuilderTests.cs, one test per point in the issue:.Skip(100).Top(50)givesOptions.Skip100 andOptions.Top50;Options == null;JsonConvert.SerializeObjectof a.Skip(100)request contains"skip":100and no"top".dotnet test: 11 passed.dotnet build QuickbaseNetgives 0 warnings and 0 errors across its targets. I ran both with the .NET 8 SDK, offline in a container.