docs(exec): remove the sh driver - #97
Merged
Merged
Conversation
The sh driver was removed in hephbuild/heph#397 (heph@44ccc91): its `sh -u -e` run has no portable pipefail, so a pipeline reported only its last stage's status and a failing producer could look like a success. The exec plugin now registers two drivers, exec and bash, and bash is a pipefail-safe superset of what sh offered. Updates the Exec plugin page, the buildfile example that used `driver = "sh"`, and the sh mentions across the heph-expert and heph-go skill/agent/command references (per the reference-drift rule in CLAUDE.md), bumping both plugins' and the marketplace's patch version.
⚡ Cloudflare Pages preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hephbuild/heph#397 (commit
44ccc91) removed theshdriver frompluginexec.sh -u -ehad no portablepipefail, so a failing pipeline producer could report success and get cached as a passing build.driver = "sh"now fails to resolve (driver not found: sh); thebashdriver is a strict superset (same-u -e, plus-o pipefail) and is the replacement.This PR removes the
shdriver from the docs:website/docs/plugins/exec.md— down to two drivers (exec,bash); dropped thebuiltin: shconfig example and theshrow from the driver table.website/docs/plugins/buildfile.md— thedriver = "sh"example now usesbash; the driver-forwarding note no longer listssh.plugins/heph-expert/**andplugins/heph-go/**(skill references, agent, and slash-command docs) — everybash/shmention updated to justbash, per the reference-drift rule in the repo'sCLAUDE.md. Bumpedheph-expertandheph-goto0.1.2, and the marketplace to0.1.2.No new page was added and no sidebar changes were needed — this is a removal, not a new feature.
Test plan
build) — not run in this environment; markdown-only edits, no code fences or links changed beyond existing patterns.sh-driver references (bash/sh,builtin: sh,driver = "sh") after edits — none remain outside of unrelated matches (code-fence language tags, thehostbindoc's//@heph/bin:shhost-binary wrapper, which is unrelated).Generated by Claude Code