docs(go): drop stale embed_test mention from the go plugin reference - #99
Merged
Conversation
The go provider no longer generates embed / embed_test / embed_xtest targets — go_compile resolves the //go:embed config in-process now (hephbuild/heph#400). Remove the stale embed_test mention from the "Generated targets" internal-variants list in the heph-go plugin reference; the other names there are still accurate. Ref: hephbuild/heph@6a546a7
⚡ Cloudflare Pages preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hephbuild/heph#400 (commit
6a546a7) removed the go provider'sembed/embed_test/embed_xtesttargets —go_compilenow resolves the//go:embedconfig in-process, so those names are no longer listed or resolvable at all.website/docs/plugins/go.mdnever mentioned these target names, so no change is needed there. But the "Generated targets" section of theheph-goClaude Code plugin's reference doc (plugins/heph-go/skills/heph-go/references/go-plugin.md) listedembed_testalongside the other internal-variant target names — that mention is now stale and is removed. The other names in that list (build_test_lib,build_xtest_lib,build_testmain_lib,testmain) are still accurate against the go provider's currentTEST_TARGET_NAMES/GOLIST_TARGET_NAMESconstants.Test plan
website/docs/**) referenceembed/embed_test/embed_xtest.crates/plugin-go/src/plugingo/provider.rsonhephbuild/heph@masterto confirm the remaining internal-variant names are still correct.Generated by Claude Code