Repository navigation
Conversation
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
commented
Nov 13, 2026
cerisier
marked this pull request as ready for review
November 13, 2026 10:38
Serve fresh selected-target metadata through the matching Zig SDK protocol while retaining the legacy 0.16 route. Own metadata subprocess cancellation and cleanup, and supply a reproducible ZLS build with the upstream absolute-path correction.
cerisier
force-pushed
the
cerisier/zls-0.17-parity
branch
from
November 13, 2026 10:41
0b974a5 to
6819f1f
Compare
aherrmann
reviewed
Nov 17, 2026
| const darwin_wexited = 0x4; | ||
| const darwin_wnowait = 0x20; | ||
|
|
||
| extern "c" fn waitid(c_uint, c_uint, *std.c.siginfo_t, c_int) c_int; |
Member
There was a problem hiding this comment.
On Linux stdlib provides waitid, that could remove the need for the libc dependency on Linux.
Saving through source.fixAll and source.organizeImports launches ast-check twice. Supervising each command adds a 250 ms cleanup grace period even after the SDK exits. Replace the proxy with the SDK for ordinary compiler commands, preserving its process group, streams and native exit status. Keep supervision for the editor session and metadata service. Cover passthrough PID, arguments, streams, environment, working directory and exit status in the consumer test.
teh-cmc
pushed a commit
to zml/zml
that referenced
this pull request
Nov 18, 2026
Saving Zig files runs two synchronous code actions. The compiler proxy adds a 250 ms cleanup wait to each `zig ast-check`, making every save noticeably slower. Pin rules_zig to `fdad034e362e5de4190bd704cc8d17907117c57e` from [rules_zig #705](hermeticbuild/rules_zig#705), where SDK commands replace the proxy process directly and avoid that delay. Checked on macOS ARM64 with `bazel build --config=remote //:completion` and the Neovim Lua/LSP save emulation using the existing Zig 0.17.0 SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZLS on Zig 0.17 asks the Zig executable for build metadata. In Bazel workspaces, that metadata needs to come from the Bazel target graph for editor navigation to resolve imports and generated sources.
The 0.17 launcher serves fresh Bazel metadata through Zig's native build protocol. A patched ZLS prebuilt preserves absolute source paths, and the consumer test exercises go-to-definition and reload against a Bazel workspace. Zig 0.16 continues to use its custom build runner.