refactor: use @heroku/sdk for redis commands#3829
Merged
Merged
Conversation
k80bowman
temporarily deployed
to
AcceptanceTests
July 23, 2026 14:25 — with
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
July 23, 2026 14:25 — with
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
July 23, 2026 14:25 — with
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
July 23, 2026 14:25 — with
GitHub Actions
Inactive
jdodson
approved these changes
Jul 23, 2026
jdodson
left a comment
Contributor
There was a problem hiding this comment.
Approved with a thing you prob want to fix.
- Looked over the PR, looks good
- Code went over with a claude & chatgpt reviewer, looks good
- Manual testing found a thing:
Doing this:
./bin/run redis:stats-reset redis-concave-96888 -a nodejs-getting-starteeed
Since I don't pass the confirm, I have to type it in, but the type in area is mangled. Looks like what's happening is that characters are already there so when I type something it's wrong. Could just be me, but maybe not?
Screenshot below:
k80bowman
temporarily deployed
to
AcceptanceTests
July 23, 2026 17:57 — with
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
July 23, 2026 17:57 — with
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
July 23, 2026 17:57 — with
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
July 23, 2026 17:57 — with
GitHub Actions
Inactive
Contributor
Author
|
I was unable to reproduce that bug, but I did fix the extra |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the
rediscommand family off the rawAPIClientin@heroku-cli/commandonto@heroku/sdk(with theredisExtensionsextension). Every command in the topic —redis(info),redis:cli,redis:credentials,redis:keyspace-notifications,redis:maxmemory,redis:promote,redis:stats-reset,redis:timeout,redis:upgrade,redis:wait— now resolves the addon and fetches Redis state through the SDK'sdata.redis/platform.addOn/platform.configVarsurfaces, and the legacysrc/lib/redis/api.tshelper is removed. Unit tests are updated to stub@heroku/sdkdirectly in place of the previousnockHTTP mocks.Also bumps the pinned
@heroku/sdkgit dependency to the latest SHA to pick up upstream fixes required by these commands.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
redis:promote) it helps if you have two Redis addons attached.npm run build) and run with./bin/runSteps:
heroku redis -a <app>— confirm info renders for the default Redis addon (headered output with config-var list and info rows).heroku redis -a <app> --json— confirm JSON output filters outformation,metaas_source, andportfields and includesconfig_vars.heroku redis:credentials <addon> -a <app>and--reset— confirm the credentials URL is returned and reset completes.heroku redis:info <addon> -a <app>— confirm addon-scoped info renders correctly.heroku redis:keyspace-notifications <addon> -a <app>(view and set),redis:maxmemory,redis:timeout— confirm reads and writes round-trip.heroku redis:stats-reset <addon> -a <app>— confirm reset succeeds.heroku redis:promote <addon> -a <app>— confirm the addon is promoted to the primary attachment.heroku redis:upgrade <addon> -a <app> --version <version>— confirm the upgrade kicks off.heroku redis:wait <addon> -a <app>— confirm it polls until the addon reachesavailable.heroku redis:cli <addon> -a <app>— confirm the interactive session opens on a non-shield plan and is blocked with the shield guidance messageon a shield plan.
npm test— full unit suite (including the rewritten Redis specs) should pass.Screenshots (if applicable)
Related Issues
GUS work item: W-23374158