feat: replace kolkrabbi API with api.heroku.com repositories-api#3830
Open
chap wants to merge 1 commit into
Open
feat: replace kolkrabbi API with api.heroku.com repositories-api#3830chap wants to merge 1 commit into
chap wants to merge 1 commit into
Conversation
Migrate all legacy kolkrabbi.heroku.com usage onto the new repositories-api
served from api.heroku.com (Accept: application/vnd.heroku+json; version=3.repositories-api).
The new API proxies GitHub server-side, so the CLI no longer fetches or handles
raw GitHub tokens.
Endpoint changes:
- POST /pipelines/{id}/repo {repo_url} to link a repo (was kolkrabbi /repository)
- GET /pipelines/{id}/repo returns the GitHub repo object (full_name, etc.)
- GET /apps/{id}/repo for app repo lookup
- GET /repos/{owner}/{name} for repo-by-name lookup
- GET /repos/{owner}/{name}/archives/{ref} for source archives
- GET /pipelines/{id}/repo/compare for commit comparison
CI commands (ci:run, ci:rerun, ci:debug) derive the test-run organization from
the pipeline owner (GET /pipelines/{id}, version=3.pipelines) since /repo no
longer returns an organization.
pipelines:setup now configures review apps via the platform review-app-config
endpoint. The repositories-api has no equivalent for staging auto-deploy or CI
auto-run enablement, so those settings (and their now-dead prompts) are removed.
reviewapps:enable/disable do a full cutover: the dashboard-repositories-api
feature gate and kolkrabbi fallback are removed.
Deletes kolkrabbi-api.ts, github-api.ts, get-github-token.ts, get-ci-settings.ts,
and the kolkrabbi TS interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates all legacy
kolkrabbi.heroku.comusage in the CLI onto the new repositories-api served fromapi.heroku.com(Accept: application/vnd.heroku+json; version=3.repositories-api). Schema: heroku/repositories-apischema/schema.json.The new API proxies GitHub server-side, so the CLI no longer fetches or handles raw GitHub tokens (
get-github-token.ts/github-api.tsare gone).Endpoint mapping
POST /pipelines/{id}/repository {repository}POST /pipelines/{id}/repo {repo_url}GET /pipelines/{id}/repositoryGET /pipelines/{id}/repo(returns GitHub repo object)GET /apps/{id}/github(.repo)GET /apps/{id}/repo(.full_name)GET /repos/{owner}/{name}GET /github/repos/{repo}/tarball/{ref}GET /repos/{owner}/{name}/archives/{ref}GET /pipelines/{id}/repo/compareNotable behavior changes
ci:run,ci:rerun,ci:debug):/repono longer returns an organization, so the test-runorganizationis derived from the pipeline owner viaGET /pipelines/{id}(version=3.pipelines) — team owner →owner.name ?? owner.id, otherwise omitted.pipelines:setup: review apps are configured through the platformreview-app-configendpoint. The repositories-api has no equivalent for the old staging auto-deploy or CI auto-run enablement, so those settings — and their now-dead interactive prompts inget-settings.ts— are removed.reviewapps:enable/disable: full cutover — thedashboard-repositories-apifeature gate and kolkrabbi fallback are removed.Removed files
kolkrabbi-api.ts,github-api.ts,setup/get-github-token.ts,setup/get-ci-settings.ts,ci/interfaces/kolkrabbi.ts.Testing
yarn build✅anywarnings only) ✅api.heroku.com; added a team-owned-pipeline org-derivation test forci:run) ✅kolkrabbireferences remain insrc/ortest/✅