Skip to content

MOB-33712: Добавил возможность настраивать dashed stroke для StrokeToken - #29

Open
nschpy wants to merge 6 commits into
mainfrom
MOB-33712
Open

MOB-33712: Добавил возможность настраивать dashed stroke для StrokeToken#29
nschpy wants to merge 6 commits into
mainfrom
MOB-33712

Conversation

@nschpy

@nschpy nschpy commented Mar 18, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@nschpy
nschpy requested a review from almazrafi March 18, 2025 22:37
Comment on lines 15 to +23
switch type {
case .inside:
return .zero
return width * 0.5

case .outside:
return -width
return -width * 0.5

case .center:
return -width * 0.5
return .zero

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Эти изменения коснутся и UIKit, а для него как-будто нет интеграции

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не заметил StrokeLayer, сейчас добавлю dashed и туда

@steve-jobs-bot

Copy link
Copy Markdown
15 Warnings
⚠️ Levitan.xcodeproj#L0 - Levitan.xcodeproj#L0: tasks in 'Copy Headers' are delayed by unsandboxed script phases; set ENABLE_USER_SCRIPT_SANDBOXING=YES to enable sandboxing
⚠️ Sources/Component/Modifiers/ComponentFrame.swift#L4 - TODOs should be resolved (Дополнить документацию)
todo ComponentFrame.swift:4
⚠️ Sources/Component/Modifiers/ComponentModifier.swift#L4 - TODOs should be resolved (Дополнить документацию)
todo ComponentModifier.swift:4
⚠️ Sources/Misc/ViewArrayBuilder.swift#L3 - TODOs should be resolved (Добавить документацию)
todo ViewArrayBuilder.swift:3
⚠️ Sources/Misc/ViewBindable.swift#L3 - TODOs should be resolved (Добавить документацию)
todo ViewBindable.swift:3
⚠️ Sources/Misc/ViewBinding.swift#L4 - TODOs should be resolved (Добавить документацию)
todo ViewBinding.swift:4
⚠️ Sources/Misc/ViewEnvironment.swift#L3 - TODOs should be resolved (Добавить документацию)
todo ViewEnvironment.swift:3
⚠️ Sources/Misc/ViewFocusBinding.swift#L3 - TODOs should be resolved (Добавить документацию)
todo ViewFocusBinding.swift:3
⚠️ Sources/Misc/ViewFocusState.swift#L3 - TODOs should be resolved (Добавить документацию)
todo ViewFocusState.swift:3
⚠️ Sources/Misc/ViewFocusState.swift#L15 - TODOs should be resolved (Перенести наработки из проекта…)
todo ViewFocusState.swift:15
⚠️ Sources/Misc/ViewState.swift#L48 - TODOs should be resolved (Добавить поддержку в компонент…)
todo ViewState.swift:48
⚠️ Sources/Token/Presentation/UIKit/Properties/Extensions/TokenViewProperties+UINavigationBar.swift#L54 - TODOs should be resolved (implement for appearance)
todo TokenViewProperties+UINavigationBar.swift:54
⚠️ Sources/Token/Presentation/UIKit/Properties/Extensions/TokenViewProperties+UITabBar.swift#L36 - TODOs should be resolved (implement for appearance)
todo TokenViewProperties+UITabBar.swift:36
⚠️ Sources/Token/Presentation/UIKit/Properties/Extensions/TokenViewProperties+UIToolbar.swift#L31 - TODOs should be resolved (implement for appearance)
todo TokenViewProperties+UIToolbar.swift:31
⚠️ Sources/Token/Value/Typography/TypographyValue.swift#L24 - TODOs should be resolved (Удалить после миграции в проек…)
todo TypographyValue.swift:24
2 Messages
📖 Levitan Tests iOS: Executed 0 tests, with 0 failures (0 expected) in 0 (0.0) seconds
📖 Levitan Tests tvOS: Executed 0 tests, with 0 failures (0 expected) in 0 (0.0) seconds

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants