fix(actor): drop on_stop claim from unwind error record; update Cargo.lock - #127
Merged
Merged
Conversation
The record is written from `LifecycleChannels::drop`, which cannot tell which phase panicked. When `on_stop` itself panics, "on_stop is not called" states the opposite of what happened. Keep only the part that holds on every unwind path: queued messages are discarded.
Bump cfg-if, libc, log, smallvec (1.15 -> 1.16), syn, tokio-macros, unicode-ident and zerocopy to the latest Rust 1.75-compatible releases. tokio-macros 2.7.2 now depends on syn 3 instead of syn 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
063bb33was pushed tofeat/panic-diagnosticsafter feat(actor): name the actor in an error record when its task ends during a panic unwind #125 was merged, so it never reachedmain. Cherry-picked here. The panic-unwind error record no longer claimson_stopwas not called; it keeps only what holds on every unwind path (queued messages are discarded).cargo updateagainst the MSRV-aware resolver. Bumps cfg-if, libc, log, smallvec (1.15 -> 1.16), syn, tokio-macros, unicode-ident, zerocopy. tokio-macros 2.7.2 now depends on syn 3 instead of syn 2; syn 3 was already in the lockfile via futures-macro.cargo update --dry-run --verbosereports nothing left to bump within Rust 1.75. Held back: rand 0.10 (needs 1.85) and syn 2 -> 3 (major).Verification (local, Rust 1.75.0)
cargo build --all-features --all-targetscargo clippy --all-targets --all-features -- -D warningscargo doc --no-depscargo test: 351 passed, 0 failedcargo test --all-features: 458 passed, 0 failedStable:
cargo fmt --checkand clippy with-D warningspass.🤖 Generated with Claude Code