You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix corpus capture after the storage crate split - #90
The 2.0.0 candidate stops while producing conformance-compacted.pop: capture invokes pop-core --features storage, but storage and the compat_checkpoint example moved to pop-storage.
Run the existing checkpoint example from its owning crate and remove the obsolete feature flag. No stored formats or compatibility markers change.
Validation: reproduced the exact Cargo feature error locally before the fix. Complete local compat:capture 2.0.0 passed against this commit, including the compacted document, PNG/PDF exports, command probes, and native page-scenario recording. Output was retained outside the repository; it is rehearsal evidence, not a publication candidate. Full bun run verify passed, including all 516 Rust tests. The failed candidate published nothing.
No actionable comments were generated in the recent review.
Summary
Updates the corpus capture command to run compat_checkpoint from the pop-storage package, without the obsolete storage feature flag.
Merge risk: Low. The change is limited to the checkpoint command in a capture script. It does not change production storage or runtime code.
Document compatibility: not affected. The script’s Cargo invocation changes, but the diff does not change stored formats, compatibility markers, or document behavior. No production Loro/CRDT changes are present.
Checks: No completed CI, build, or test results are available. The author reported that a full corpus capture was running, but its completion is not established.
Still needed: Confirm the capture completes and produces the expected corpus artifacts.
The compatibility checkpoint command now runs the compat_checkpoint example from the pop-storage package instead of pop-core with the storage feature.
hitSlop/dotpop#72: This PR changes the release workflow step that runs compatibility capture. PR #90 changes the command used by that capture step.
Merge Risk: Minimal · up to 9b584
The command now selects the checkpoint example from its owning package without the obsolete feature flag. No actionable merge-blocking risk is established.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title names the main change: corpus capture is fixed after the storage crate split. The changeset points the capture command at the compat_checkpoint example in pop-storage instead of pop-core wit…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description follows the template's intent. It explains the problem and the fix: capture ran pop-core --features storage, and the storage crate and compat_checkpoint example moved to `pop-stora…
Full details: Title check
Explanation
The title names the main change: corpus capture is fixed after the storage crate split. The changeset points the capture command at the compat_checkpoint example in pop-storage instead of pop-core with the storage feature, so the title matches the change.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Full details: Description check
Explanation
The description follows the template's intent. It explains the problem and the fix: capture ran pop-core --features storage, and the storage crate and compat_checkpoint example moved to pop-storage. It states that no stored formats or compatibility markers change. It gives concrete validation: the Cargo feature error was reproduced before the fix, a full local compat:capture 2.0.0 run passed, and bun run verify passed with 516 Rust tests. The template's 'How was it verified?' tier checklist is not marked, and the description does not say whether the native checks or the release:check tier applied. Screenshots, regenerated artifacts, and secrets checks are not addressed. These are mostly non-critical for a small scripts-only change, so the check passes.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
One package shifts in the capture command The checkpoint example finds its new home pop-storage now takes the call The old feature flag leaves the line A small change guides the run anew
Reviewing files that changed from the base of the PR and between 5daf044 and 9b58480.
Files selected for processing: 1
scripts/compat/capture.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.0.0 candidate stops while producing
conformance-compacted.pop: capture invokespop-core --features storage, but storage and thecompat_checkpointexample moved topop-storage.Run the existing checkpoint example from its owning crate and remove the obsolete feature flag. No stored formats or compatibility markers change.
Validation: reproduced the exact Cargo feature error locally before the fix. Complete local
compat:capture 2.0.0passed against this commit, including the compacted document, PNG/PDF exports, command probes, and native page-scenario recording. Output was retained outside the repository; it is rehearsal evidence, not a publication candidate. Fullbun run verifypassed, including all 516 Rust tests. The failed candidate published nothing.