Repository navigation
fix(devtools): stable PendingLane key + real TypeScript typecheck in CI - #21
Merged
Merged
Conversation
PendingLane rendered every item with key={undefined} because QueueItem has
no key field, breaking React reconciliation for the Web APIs lane. Build a
stable key from the item id (p<id>) matching the pattern already used in
Workbench for the same data.
Also close the TypeScript CI gap:
- add "typecheck": "tsc --noEmit" to package.json
- run it in CI between lint and build
- fix all pre-existing tsc errors so the typecheck passes cleanly:
- dataset/search index-signature access (noPropertyAccessFromIndexSignature)
- optional props that receive explicit undefined (exactOptionalPropertyTypes)
- 404 Link missing required search param
Co-authored-by: monkeycode-ai <monkeycode-ai@chaitin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two focused fixes:
1. PendingLane renders with an undefined key
PendingLaneinLoopDiagram.tsxusedkey={item.key}, butQueueItemonly has{ id, label }— there is nokeyfield. Every item rendered withkey={undefined}, breaking React reconciliation (and the enter/exit animation) for the Web APIs lane and triggering a React key warning.Fixed by building a stable key
p${item.id}locally in the render, the same patternWorkbench.tsxalready uses for the identical data. No change to theQueueItemtype.2. Close the TypeScript CI gap
vite buildonly strips types, so real type errors could land onmainundetected."typecheck": "tsc --noEmit"topackage.json..github/workflows/ci.yml(between lint and build).tsc --noEmitreports so the check passes cleanly:.fordataset.*and the searchRecord(noPropertyAccessFromIndexSignature) —AppShell.tsx,Timeline.tsx,routes/index.tsx.undefined(exactOptionalPropertyTypes) —PatternLibrary.tsx,SourcesView.tsx, and thevalidateSearchreturn type.Linkto/missing the now-requiredsearch={{ tab: "timeline" }}param.Verification
bun run typecheck— passesbun test— 31 pass, 0 failbun run lint— 0 errors (only pre-existing warnings)bun run build— succeeds