Repository navigation
fix(workbench): share-card highlight width, cursor, step-0, HiDPI - #30
Merged
Merged
Conversation
…I correctly - Full-width active-line highlight matching live CodeMirror instead of an arbitrary text-width cutoff - Remove the stray yellow cursor bar (static export has no editor caret) - Step 0 (no trace step) renders no focus line instead of falsely highlighting line 1 - Render the canvas backing store at devicePixelRatio (capped at 3x) so exports stay sharp on HiDPI displays Co-authored-by: monkeycode-ai <monkeycode-ai@chaitin.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fix to the share-as-image feature (PR #29).
Changes
devicePixelRatio(capped at 3x) with actx.scale(dpr, dpr), so PNG exports stay sharp on HiDPI/retina displays. The exported image remains 1200x630 logical px; verified adeviceScaleFactor: 2context produces a 2400x1260 PNG with measurably sharper edges.Verification
npm run typecheck,npm run lint(0 errors),npm test(58 pass / 1354 expects),npm run buildall green.