fix(dev-server): use public ssrModule getter in handleHotUpdate - #353
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b71f0ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Thank you! I'll merge and release a new version. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed
(ssr) page reloadnever appears when editing SSR modules, so there's no way to tell from the terminal if SSR reload is working. The page does reload, but only because Vite's HMR bubbles up as a fallback, not through the intended explicitfull-reloadpath.The cause is
handleHotUpdate(#233 / #235) checkingmod._ssrModule, a private internal field on Vite's compat ModuleNode. This replaces it withmod.ssrModule, the public getter that works across Vite 5 through 8. No compatibility concerns. Confirmed client modules are unaffected.