Contain interactions that race provider turn acceptance - #19
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The app-server can write a
turn/startresponse and an interaction request in one stdout drain. SessionService may dispatch that request after resolvingstartTurnbut before ChatService binds the returned provider turn ID. The existing exact-turn guard then treated an owned request as foreign and missed fail-closed containment.Main CI run
32324202341exposed this timing incompiled gateway boundary > hosts durable chat panes with independent admission, fenced streams, and fail-closed interaction recovery:settlementObservedremained false after 7.31 seconds.Design
Tests
bun run check: all changed-area tests passed; 2,929/2,936 workspace tests passed. The seven failures are unchanged bundled-Git sandbox/process-group tests that passed on the preceding GitHub PR and remain delegated to required GitHub CI.