Repository navigation
fix(lore-memory): match a one-word prompt against note titles only - #421
Merged
Merged
Conversation
"Yes, review them" and "Yes, build them" matched any note whose statement held the word: "List follow-up items in chat" and the external-SSD note. With one content word, the note's title must hold it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a prompt has one content word,
fts_relatedmatches notes whose title holds it (was: anywhere in the lesson statement). Two-word matching is unchanged.Why
On the owner's last 60 real prompts (same harness as #420, hook run against a vault copy): one-word go-aheads were the main remaining false positives. "Yes, review them" got "List follow-up items in chat instead of filing them to a team tracker", and "Yes, build them" got the external-SSD note. After: 20 → 18 notes, both gone, every relevant one kept ("Throttle Xcode builds", "Run /code-review…", "Resolve review threads…", the merge notes).
Test
New
a_one_word_prompt_matches_titles_only(fails on main: both notes returned). Query-shape unit test updated. README sentence updated.cargo test --no-fail-fast -p lore-memory -p lorectlpasses; clippy clean.