Repository navigation
Conversation
list_proposals now names, per pending proposal, the first earlier pending proposal or else active note with a near-identical title in a covering scope. The review card says so in one line and offers Reject as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
list_proposalsaddsrepeats: { id, title, kind: "note" | "proposal" } | nullto eachProposalDto: the first earlier pending proposal, or else active note, whose title is near-identical (duplicates::near_identical) in the same scope or global (mirrorsalready_filedfrom fix(lorectl): refuse a proposal that repeats a pending one or an active note #412). Updates are never marked.Same as a lesson you haven't reviewed: <title>/Already a note: <title>) and a Reject as duplicate button that rejects with reasonduplicate of <id>.Why
The inbox has near-duplicate pairs (the same lesson filed twice, reworded). Each had to be read and rejected by hand.
Test
a_proposal_that_repeats_an_older_one_or_a_note_names_it(earlier proposal, active note, global covering repo, later/repo-scoped not marked, update skipped, unrelated not marked); IPC round-trip.duplicate of N1; no button when nothing repeats.