Repository navigation
fix: honor Reverse Scroll Direction for trackpad/mouse scrolling - #116
Open
MoustacheOff wants to merge 1 commit into
Open
MoustacheOff wants to merge 1 commit into
MoustacheOff wants to merge 1 commit into
Conversation
Collaborator
|
@MoustacheOff thanks for the fix and for testing it, #97 just merged and adds a fractional accumulator to the same two handlers (one per mouse), so this conflicts now |
Collaborator
|
and keep the default as is, flipping it would change the direction for every mouse user on update |
The GCMouse scroll handlers ignored the reverseScrollDirection setting, which was only read in the touch two-finger scroll path. Fixes hugeBlack#115
MoustacheOff
force-pushed
the
fix/trackpad-scroll-direction
branch
from
October 19, 2026 22:21
6d3af31 to
ccd8a2e
Compare
Author
|
Rebased on main, it now only adds the reverse scroll direction on top of #97's accumulators. Default unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #115.
Apply
SettingsHandler.reverseScrollDirectionin theGCMousescroll handlers (GameController.swift). It was only read in the touch two-finger scroll path, so the toggle had no effect for a trackpad or mouse.Rebased on main after #97; this only adds the direction on top of its accumulators. The default is unchanged.